/mandos/trunk : contents of plugin-runner.c at revision 132

: (revision 132)

To get this branch, use:

bzr branch
http://bzr.recompile.se/loggerhead/mandos/trunk

21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	1	/* -- coding: utf-8 -- */
	2	/*
	3	* Mandos plugin runner - Run Mandos plugins
	4	*
28 by Teddy Hogeborn * server.conf: New file.	5	* Copyright © 2007-2008 Teddy Hogeborn & Björn Påhlsson
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	6	*
	7	* This program is free software: you can redistribute it and/or
	8	* modify it under the terms of the GNU General Public License as
	9	* published by the Free Software Foundation, either version 3 of the
	10	* License, or (at your option) any later version.
	11	*
	12	* This program is distributed in the hope that it will be useful, but
	13	* WITHOUT ANY WARRANTY; without even the implied warranty of
	14	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
	15	* General Public License for more details.
	16	*
	17	* You should have received a copy of the GNU General Public License
	18	* along with this program. If not, see
	19	* <http://www.gnu.org/licenses/>.
	20	*
28 by Teddy Hogeborn * server.conf: New file.	21	* Contact the authors at <mandos@fukt.bsnet.se>.
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	22	*/
	23
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	24	#define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), getline(),
	25	asprintf() */
24.1.26 by Björn Påhlsson tally count of used symbols	26	#include <stddef.h> /* size_t, NULL */
	27	#include <stdlib.h> /* malloc(), exit(), EXIT_FAILURE,
	28	EXIT_SUCCESS, realloc() */
	29	#include <stdbool.h> /* bool, true, false */
	30	#include <stdio.h> /* perror, popen(), fileno(),
	31	fprintf(), stderr, STDOUT_FILENO */
	32	#include <sys/types.h> /* DIR, opendir(), stat(), struct
	33	stat, waitpid(), WIFEXITED(),
	34	WEXITSTATUS(), wait(), pid_t,
	35	uid_t, gid_t, getuid(), getgid(),
	36	dirfd() */
	37	#include <sys/select.h> /* fd_set, select(), FD_ZERO(),
	38	FD_SET(), FD_ISSET(), FD_CLR */
	39	#include <sys/wait.h> /* wait(), waitpid(), WIFEXITED(),
	40	WEXITSTATUS() */
	41	#include <sys/stat.h> /* struct stat, stat(), S_ISREG() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	42	#include <iso646.h> /* and, or, not */
	43	#include <dirent.h> /* DIR, struct dirent, opendir(),
24.1.26 by Björn Påhlsson tally count of used symbols	44	readdir(), closedir(), dirfd() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	45	#include <unistd.h> /* struct stat, stat(), S_ISREG(),
24.1.26 by Björn Påhlsson tally count of used symbols	46	fcntl(), setuid(), setgid(),
	47	F_GETFD, F_SETFD, FD_CLOEXEC,
	48	access(), pipe(), fork(), close()
	49	dup2, STDOUT_FILENO, _exit(),
	50	execv(), write(), read(),
	51	close() */
	52	#include <fcntl.h> /* fcntl(), F_GETFD, F_SETFD,
	53	FD_CLOEXEC */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	54	#include <string.h> /* strsep, strlen(), asprintf() */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	55	#include <errno.h> /* errno */
24.1.26 by Björn Påhlsson tally count of used symbols	56	#include <argp.h> /* struct argp_option, struct
	57	argp_state, struct argp,
	58	argp_parse(), ARGP_ERR_UNKNOWN,
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	59	ARGP_KEY_END, ARGP_KEY_ARG,
	60	error_t */
24.1.26 by Björn Påhlsson tally count of used symbols	61	#include <signal.h> /* struct sigaction, sigemptyset(),
	62	sigaddset(), sigaction(),
	63	sigprocmask(), SIG_BLOCK, SIGCHLD,
	64	SIG_UNBLOCK, kill() */
	65	#include <errno.h> /* errno, EBADF */
13 by Björn Påhlsson Added following support:	66
37 by Teddy Hogeborn Non-tested commit for merge purposes.	67	#define BUFFER_SIZE 256
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	68
	69	#define PDIR "/lib/mandos/plugins.d"
	70	#define AFILE "/conf/conf.d/mandos/plugin-runner.conf"
37 by Teddy Hogeborn Non-tested commit for merge purposes.	71
74 by Teddy Hogeborn * Makefile (PREFIX, CONFDIR): New.	72	const char *argp_program_version = "plugin-runner 1.0";
24.1.35 by Björn Påhlsson version 1.0	73	const char *argp_program_bug_address = "<mandos@fukt.bsnet.se>";
24.1.35 by Björn Påhlsson version 1.0	74
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	75	struct plugin;
	76
	77	typedef struct plugin{
	78	char name; / can be NULL or any plugin name */
	79	char **argv;
	80	int argc;
	81	char **environ;
	82	int envc;
	83	bool disabled;
	84
	85	/* Variables used for running processes*/
13 by Björn Påhlsson Added following support:	86	pid_t pid;
	87	int fd;
	88	char *buffer;
21 by Teddy Hogeborn * Makefile (CFLAGS): Changed to use $(WARN), $(DEBUG), $(COVERAGE) and	89	size_t buffer_size;
	90	size_t buffer_length;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	91	bool eof;
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	92	volatile bool completed;
	93	volatile int status;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	94	struct plugin *next;
	95	} plugin;
	96
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	97	static plugin *plugin_list = NULL;
	98
	99	/* Gets a existing plugin based on name,
	100	or if none is found, creates a new one */
	101	static plugin getplugin(char name){
	102	/* Check for exiting plugin with that name */
	103	for (plugin *p = plugin_list; p != NULL; p = p->next){
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	104	if ((p->name == name)
	105	or (p->name and name and (strcmp(p->name, name) == 0))){
	106	return p;
	107	}
	108	}
	109	/* Create a new plugin */
	110	plugin *new_plugin = malloc(sizeof(plugin));
	111	if (new_plugin == NULL){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	112	return NULL;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	113	}
24.1.62 by Björn Påhlsson merge + small bugfix	114	char *copy_name = NULL;
	115	if(name != NULL){
	116	copy_name = strdup(name);
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	117	if(copy_name == NULL){
	118	return NULL;
	119	}
24.1.54 by Björn Påhlsson plugin-runner	120	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	121
24.1.54 by Björn Påhlsson plugin-runner	122	*new_plugin = (plugin) { .name = copy_name,
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	123	.argc = 1,
	124	.disabled = false,
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	125	.next = plugin_list };
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	126
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	127	new_plugin->argv = malloc(sizeof(char ) 2);
	128	if (new_plugin->argv == NULL){
24.1.62 by Björn Påhlsson merge + small bugfix	129	free(copy_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	130	free(new_plugin);
	131	return NULL;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	132	}
24.1.54 by Björn Påhlsson plugin-runner	133	new_plugin->argv[0] = copy_name;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	134	new_plugin->argv[1] = NULL;
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	135
	136	new_plugin->environ = malloc(sizeof(char *));
	137	if(new_plugin->environ == NULL){
24.1.62 by Björn Påhlsson merge + small bugfix	138	free(copy_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	139	free(new_plugin->argv);
	140	free(new_plugin);
	141	return NULL;
	142	}
	143	new_plugin->environ[0] = NULL;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	144
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	145	/* Append the new plugin to the list */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	146	plugin_list = new_plugin;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	147	return new_plugin;
	148	}
	149
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	150	/* Helper function for add_argument and add_environment */
	151	static bool add_to_char_array(const char new, char **array,
	152	int *len){
	153	/* Resize the pointed-to array to hold one more pointer */
	154	array = realloc(array, sizeof(char *)
	155	* (size_t) ((*len) + 2));
	156	/* Malloc check */
	157	if(*array == NULL){
	158	return false;
	159	}
	160	/* Make a copy of the new string */
	161	char *copy = strdup(new);
	162	if(copy == NULL){
	163	return false;
	164	}
	165	/* Insert the copy */
	166	(array)[len] = copy;
	167	(*len)++;
	168	/* Add a new terminating NULL pointer to the last element */
	169	(array)[len] = NULL;
	170	return true;
	171	}
	172
	173	/* Add to a plugin's argument vector */
	174	static bool add_argument(plugin p, const char arg){
	175	if(p == NULL){
	176	return false;
	177	}
	178	return add_to_char_array(arg, &(p->argv), &(p->argc));
	179	}
	180
	181	/* Add to a plugin's environment */
	182	static bool add_environment(plugin p, const char def){
	183	if(p == NULL){
	184	return false;
	185	}
	186	return add_to_char_array(def, &(p->environ), &(p->envc));
	187	}
	188
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	189	/*
	190	* Based on the example in the GNU LibC manual chapter 13.13 "File
	191	* Descriptor Flags".
	192	* *Note File Descriptor Flags:(libc)Descriptor Flags.
	193	*/
37 by Teddy Hogeborn Non-tested commit for merge purposes.	194	static int set_cloexec_flag(int fd)
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	195	{
	196	int ret = fcntl(fd, F_GETFD, 0);
	197	/* If reading the flags failed, return error indication now. */
	198	if(ret < 0){
	199	return ret;
	200	}
	201	/* Store modified flag word in the descriptor. */
	202	return fcntl(fd, F_SETFD, ret \| FD_CLOEXEC);
	203	}
	204
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	205
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	206	/* Mark processes as completed when they exit, and save their exit
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	207	status. */
	208	void handle_sigchld(__attribute__((unused)) int sig){
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	209	while(true){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	210	plugin *proc = plugin_list;
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	211	int status;
	212	pid_t pid = waitpid(-1, &status, WNOHANG);
	213	if(pid == 0){
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	214	/* Only still running child processes */
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	215	break;
	216	}
	217	if(pid == -1){
	218	if (errno != ECHILD){
	219	perror("waitpid");
	220	}
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	221	/* No child processes */
	222	break;
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	223	}
	224
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	225	/* A child exited, find it in process_list */
24.1.65 by Björn Påhlsson * plugin-runner.c (handle_sigchld): Loop until all exited children	226	while(proc != NULL and proc->pid != pid){
	227	proc = proc->next;
	228	}
	229	if(proc == NULL){
	230	/* Process not found in process list */
	231	continue;
	232	}
	233	proc->status = status;
	234	proc->completed = true;
	235	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	236	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	237
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	238	/* Prints out a password to stdout */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	239	bool print_out_password(const char *buffer, size_t length){
64 by Teddy Hogeborn * mandos-client.c (print_out_password): Strip trailing '\n'.	240	ssize_t ret;
	241	if(length>0 and buffer[length-1] == '\n'){
	242	length--;
	243	}
	244	for(size_t written = 0; written < length; written += (size_t)ret){
24.1.42 by Björn Påhlsson Added fallback to mandos-client	245	ret = TEMP_FAILURE_RETRY(write(STDOUT_FILENO, buffer + written,
	246	length - written));
	247	if(ret < 0){
	248	return false;
	249	}
	250	}
	251	return true;
	252	}
	253
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	254	/* Removes and free a plugin from the plugin list */
	255	static void free_plugin(plugin *plugin_node){
	256
	257	for(char *arg = plugin_node->argv; arg != NULL; arg++){
	258	free(*arg);
	259	}
	260	free(plugin_node->argv);
	261	for(char *env = plugin_node->environ; env != NULL; env++){
	262	free(*env);
	263	}
	264	free(plugin_node->environ);
	265	free(plugin_node->buffer);
	266
	267	/* Removes the plugin from the singly-linked list */
	268	if(plugin_node == plugin_list){
	269	/* First one - simple */
	270	plugin_list = plugin_list->next;
	271	} else {
	272	/* Second one or later */
	273	for(plugin *p = plugin_list; p != NULL; p = p->next){
	274	if(p->next == plugin_node){
	275	p->next = plugin_node->next;
	276	break;
	277	}
	278	}
	279	}
	280
	281	free(plugin_node);
	282	}
	283
	284	static void free_plugin_list(void){
	285	while(plugin_list != NULL){
	286	free_plugin(plugin_list);
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	287	}
24.1.54 by Björn Påhlsson plugin-runner	288	}
24.1.54 by Björn Påhlsson plugin-runner	289
13 by Björn Påhlsson Added following support:	290	int main(int argc, char *argv[]){
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	291	char *plugindir = NULL;
	292	char *argfile = NULL;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	293	FILE *conffp;
24.1.5 by Björn Påhlsson plugbasedclient:	294	size_t d_name_len;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	295	DIR *dir = NULL;
13 by Björn Påhlsson Added following support:	296	struct dirent *dirst;
13 by Björn Påhlsson Added following support:	297	struct stat st;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	298	fd_set rfds_all;
13 by Björn Påhlsson Added following support:	299	int ret, maxfd = 0;
24.1.6 by Björn Påhlsson plugbasedclient	300	uid_t uid = 65534;
24.1.6 by Björn Påhlsson plugbasedclient	301	gid_t gid = 65534;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	302	bool debug = false;
	303	int exitstatus = EXIT_SUCCESS;
24.1.7 by Björn Påhlsson merge	304	struct sigaction old_sigchld_action;
	305	struct sigaction sigchld_action = { .sa_handler = handle_sigchld,
	306	.sa_flags = SA_NOCLDSTOP };
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	307	char **custom_argv = NULL;
	308	int custom_argc = 0;
	309
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	310	/* Establish a signal handler */
	311	sigemptyset(&sigchld_action.sa_mask);
	312	ret = sigaddset(&sigchld_action.sa_mask, SIGCHLD);
24.1.54 by Björn Påhlsson plugin-runner	313	if(ret == -1){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	314	perror("sigaddset");
24.1.54 by Björn Påhlsson plugin-runner	315	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	316	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	317	}
	318	ret = sigaction(SIGCHLD, &sigchld_action, &old_sigchld_action);
24.1.54 by Björn Påhlsson plugin-runner	319	if(ret == -1){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	320	perror("sigaction");
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	321	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	322	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	323	}
	324
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	325	/* The options we understand. */
	326	struct argp_option options[] = {
	327	{ .name = "global-options", .key = 'g',
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	328	.arg = "OPTION[,OPTION[,...]]",
	329	.doc = "Options passed to all plugins" },
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	330	{ .name = "global-envs", .key = 'e',
	331	.arg = "VAR=value",
	332	.doc = "Environment variable passed to all plugins" },
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	333	{ .name = "options-for", .key = 'o',
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	334	.arg = "PLUGIN:OPTION[,OPTION[,...]]",
	335	.doc = "Options passed only to specified plugin" },
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	336	{ .name = "envs-for", .key = 'f',
	337	.arg = "PLUGIN:ENV=value",
	338	.doc = "Environment variable passed to specified plugin" },
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	339	{ .name = "disable", .key = 'd',
	340	.arg = "PLUGIN",
	341	.doc = "Disable a specific plugin", .group = 1 },
24.1.5 by Björn Påhlsson plugbasedclient:	342	{ .name = "plugin-dir", .key = 128,
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	343	.arg = "DIRECTORY",
	344	.doc = "Specify a different plugin directory", .group = 2 },
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	345	{ .name = "config-file", .key = 129,
	346	.arg = "FILE",
	347	.doc = "Specify a different configuration file", .group = 2 },
	348	{ .name = "userid", .key = 130,
	349	.arg = "ID", .flags = 0,
	350	.doc = "User ID the plugins will run as", .group = 3 },
	351	{ .name = "groupid", .key = 131,
	352	.arg = "ID", .flags = 0,
	353	.doc = "Group ID the plugins will run as", .group = 3 },
	354	{ .name = "debug", .key = 132,
	355	.doc = "Debug mode", .group = 4 },
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	356	{ .name = NULL }
	357	};
	358
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	359	error_t parse_opt (int key, char arg, __attribute__((unused)) struct argp_state state) {
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	360	/* Get the INPUT argument from `argp_parse', which we know is a
	361	pointer to our plugin list pointer. */
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	362	switch (key) {
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	363	case 'g': /* --global-options */
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	364	if (arg != NULL){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	365	char *p;
	366	while((p = strsep(&arg, ",")) != NULL){
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	367	if(p[0] == '\0'){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	368	continue;
	369	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	370	if(not add_argument(getplugin(NULL), p)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	371	perror("add_argument");
	372	return ARGP_ERR_UNKNOWN;
	373	}
	374	}
	375	}
	376	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	377	case 'e': /* --global-envs */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	378	if(arg == NULL){
	379	break;
	380	}
	381	{
	382	char *envdef = strdup(arg);
	383	if(envdef == NULL){
	384	break;
	385	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	386	if(not add_environment(getplugin(NULL), envdef)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	387	perror("add_environment");
24.1.50 by Björn Påhlsson changed from using strtok to strsep	388	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	389	}
	390	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	391	case 'o': /* --options-for */
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	392	if (arg != NULL){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	393	char *p_name = strsep(&arg, ":");
	394	if(p_name[0] == '\0'){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	395	break;
	396	}
	397	char *opt = strsep(&arg, ":");
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	398	if(opt[0] == '\0'){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	399	break;
	400	}
	401	if(opt != NULL){
	402	char *p;
	403	while((p = strsep(&opt, ",")) != NULL){
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	404	if(p[0] == '\0'){
24.1.50 by Björn Påhlsson changed from using strtok to strsep	405	continue;
	406	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	407	if(not add_argument(getplugin(p_name), p)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	408	perror("add_argument");
	409	return ARGP_ERR_UNKNOWN;
	410	}
24.1.50 by Björn Påhlsson changed from using strtok to strsep	411	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	412	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	413	}
	414	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	415	case 'f': /* --envs-for */
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	416	if(arg == NULL){
	417	break;
	418	}
	419	{
	420	char *envdef = strchr(arg, ':');
	421	if(envdef == NULL){
	422	break;
	423	}
	424	char *p_name = strndup(arg, (size_t) (envdef-arg));
	425	if(p_name == NULL){
	426	break;
	427	}
	428	envdef++;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	429	if(not add_environment(getplugin(p_name), envdef)){
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	430	perror("add_environment");
	431	}
	432	}
	433	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	434	case 'd': /* --disable */
24.1.5 by Björn Påhlsson plugbasedclient:	435	if (arg != NULL){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	436	plugin *p = getplugin(arg);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	437	if(p == NULL){
	438	return ARGP_ERR_UNKNOWN;
	439	}
	440	p->disabled = true;
24.1.5 by Björn Påhlsson plugbasedclient:	441	}
24.1.5 by Björn Påhlsson plugbasedclient:	442	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	443	case 128: /* --plugin-dir */
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	444	plugindir = strdup(arg);
	445	if(plugindir == NULL){
	446	perror("strdup");
	447	}
24.1.5 by Björn Påhlsson plugbasedclient:	448	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	449	case 129: /* --config-file */
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	450	argfile = strdup(arg);
	451	if(argfile == NULL){
	452	perror("strdup");
	453	}
	454	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	455	case 130: /* --userid */
24.1.6 by Björn Påhlsson plugbasedclient	456	uid = (uid_t)strtol(arg, NULL, 10);
24.1.6 by Björn Påhlsson plugbasedclient	457	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	458	case 131: /* --groupid */
24.1.6 by Björn Påhlsson plugbasedclient	459	gid = (gid_t)strtol(arg, NULL, 10);
24.1.6 by Björn Påhlsson plugbasedclient	460	break;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	461	case 132: /* --debug */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	462	debug = true;
	463	break;
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	464	case ARGP_KEY_ARG:
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	465	fprintf(stderr, "Ignoring unknown argument \"%s\"\n", arg);
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	466	break;
	467	case ARGP_KEY_END:
	468	break;
	469	default:
	470	return ARGP_ERR_UNKNOWN;
	471	}
	472	return 0;
	473	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	474
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	475	struct argp argp = { .options = options, .parser = parse_opt,
24.1.8 by Björn Påhlsson plugbasedclient	476	.args_doc = "[+PLUS_SEPARATED_OPTIONS]",
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	477	.doc = "Mandos plugin runner -- Run plugins" };
	478
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	479	ret = argp_parse (&argp, argc, argv, 0, 0, NULL);
24.1.26 by Björn Påhlsson tally count of used symbols	480	if (ret == ARGP_ERR_UNKNOWN){
64 by Teddy Hogeborn * mandos-client.c (print_out_password): Strip trailing '\n'.	481	fprintf(stderr, "Unknown error while parsing arguments\n");
24.1.26 by Björn Påhlsson tally count of used symbols	482	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	483	goto fallback;
24.1.26 by Björn Påhlsson tally count of used symbols	484	}
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	485
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	486	/* Opens the configfile if aviable */
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	487	if (argfile == NULL){
	488	conffp = fopen(AFILE, "r");
	489	} else {
	490	conffp = fopen(argfile, "r");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	491	}
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	492	if(conffp != NULL){
	493	char *org_line = NULL;
24.1.54 by Björn Påhlsson plugin-runner	494	char p, arg, new_arg, line;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	495	size_t size = 0;
	496	ssize_t sret;
	497	const char whitespace_delims[] = " \r\t\f\v\n";
	498	const char comment_delim[] = "#";
	499
24.1.67 by Björn Påhlsson transformed a function to a part of main	500	custom_argc = 1;
	501	custom_argv = malloc(sizeof(char) 2);
	502	if(custom_argv == NULL){
	503	perror("malloc");
	504	exitstatus = EXIT_FAILURE;
	505	goto fallback;
	506	}
	507	custom_argv[0] = argv[0];
	508	custom_argv[1] = NULL;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	509
	510	/* for each line in the config file, strip whitespace and ignore commented text */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	511	while(true){
	512	sret = getline(&org_line, &size, conffp);
	513	if(sret == -1){
	514	break;
	515	}
	516
	517	line = org_line;
	518	arg = strsep(&line, comment_delim);
	519	while((p = strsep(&arg, whitespace_delims)) != NULL){
	520	if(p[0] == '\0'){
	521	continue;
	522	}
	523	new_arg = strdup(p);
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	524	if(new_arg == NULL){
	525	perror("strdup");
	526	exitstatus = EXIT_FAILURE;
	527	free(org_line);
	528	goto fallback;
	529	}
	530
24.1.67 by Björn Påhlsson transformed a function to a part of main	531	custom_argc += 1;
	532	custom_argv = realloc(custom_argv, sizeof(char *)
	533	* ((unsigned int) custom_argc + 1));
	534	if(custom_argv == NULL){
	535	perror("realloc");
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	536	exitstatus = EXIT_FAILURE;
24.1.67 by Björn Påhlsson transformed a function to a part of main	537	free(org_line);
24.1.54 by Björn Påhlsson plugin-runner	538	goto fallback;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	539	}
24.1.67 by Björn Påhlsson transformed a function to a part of main	540	custom_argv[custom_argc-1] = new_arg;
	541	custom_argv[custom_argc] = NULL;
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	542	}
	543	}
	544	free(org_line);
	545	} else{
24.1.52 by Björn Påhlsson merge + minor adjustments	546	/* Check for harmful errors and go to fallback. Other errors might
24.1.52 by Björn Påhlsson merge + minor adjustments	547	not affect opening plugins */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	548	if (errno == EMFILE or errno == ENFILE or errno == ENOMEM){
	549	perror("fopen");
24.1.8 by Björn Påhlsson plugbasedclient	550	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	551	goto fallback;
24.1.8 by Björn Påhlsson plugbasedclient	552	}
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	553	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	554	/* If there was any arguments from configuration file,
	555	pass them to parser as command arguments */
24.1.51 by Björn Påhlsson Added configuration files support for mandos-client	556	if(custom_argv != NULL){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	557	ret = argp_parse (&argp, custom_argc, custom_argv, 0, 0, NULL);
24.1.26 by Björn Påhlsson tally count of used symbols	558	if (ret == ARGP_ERR_UNKNOWN){
64 by Teddy Hogeborn * mandos-client.c (print_out_password): Strip trailing '\n'.	559	fprintf(stderr, "Unknown error while parsing arguments\n");
24.1.26 by Björn Påhlsson tally count of used symbols	560	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	561	goto fallback;
24.1.26 by Björn Påhlsson tally count of used symbols	562	}
24.1.8 by Björn Påhlsson plugbasedclient	563	}
24.1.8 by Björn Påhlsson plugbasedclient	564
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	565	if(debug){
	566	for(plugin *p = plugin_list; p != NULL; p=p->next){
	567	fprintf(stderr, "Plugin: %s has %d arguments\n",
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	568	p->name ? p->name : "Global", p->argc - 1);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	569	for(char *a = p->argv; a != NULL; a++){
	570	fprintf(stderr, "\tArg: %s\n", *a);
	571	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	572	fprintf(stderr, "...and %u environment variables\n", p->envc);
	573	for(char *a = p->environ; a != NULL; a++){
	574	fprintf(stderr, "\t%s\n", *a);
	575	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	576	}
	577	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	578
	579	/* Strip permissions down to nobody */
24.1.6 by Björn Påhlsson plugbasedclient	580	ret = setuid(uid);
	581	if (ret == -1){
	582	perror("setuid");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	583	}
24.1.6 by Björn Påhlsson plugbasedclient	584	setgid(gid);
24.1.6 by Björn Påhlsson plugbasedclient	585	if (ret == -1){
39 by Teddy Hogeborn * plugins.d/mandosclient.c (pgp_packet_decrypt): Renamed variables.	586	perror("setgid");
24.1.6 by Björn Påhlsson plugbasedclient	587	}
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	588
	589	if (plugindir == NULL){
	590	dir = opendir(PDIR);
	591	} else {
	592	dir = opendir(plugindir);
	593	}
24.1.6 by Björn Påhlsson plugbasedclient	594
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	595	if(dir == NULL){
	596	perror("Could not open plugin dir");
	597	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	598	goto fallback;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	599	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	600
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	601	/* Set the FD_CLOEXEC flag on the directory, if possible */
	602	{
	603	int dir_fd = dirfd(dir);
	604	if(dir_fd >= 0){
	605	ret = set_cloexec_flag(dir_fd);
	606	if(ret < 0){
	607	perror("set_cloexec_flag");
	608	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	609	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	610	}
	611	}
	612	}
24.1.1 by Björn Påhlsson Added syntax and support for plugbasedclient arguments and how they	613
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	614	FD_ZERO(&rfds_all);
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	615
	616	/* Read and execute any executable in the plugin directory*/
13 by Björn Påhlsson Added following support:	617	while(true){
	618	dirst = readdir(dir);
	619
	620	// All directory entries have been processed
	621	if(dirst == NULL){
24.1.26 by Björn Påhlsson tally count of used symbols	622	if (errno == EBADF){
	623	perror("readdir");
	624	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	625	goto fallback;
24.1.26 by Björn Påhlsson tally count of used symbols	626	}
13 by Björn Påhlsson Added following support:	627	break;
	628	}
	629
	630	d_name_len = strlen(dirst->d_name);
	631
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	632	// Ignore dotfiles, backup files and other junk
	633	{
	634	bool bad_name = false;
	635
	636	const char const *bad_prefixes[] = { ".", "#", NULL };
	637
	638	const char const *bad_suffixes[] = { "~", "#", ".dpkg-new",
	639	".dpkg-old",
	640	".dpkg-divert", NULL };
	641	for(const char *pre = bad_prefixes; pre != NULL; pre++){
	642	size_t pre_len = strlen(*pre);
	643	if((d_name_len >= pre_len)
	644	and strncmp((dirst->d_name), *pre, pre_len) == 0){
	645	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	646	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	647	" with bad prefix %s\n", dirst->d_name, *pre);
	648	}
	649	bad_name = true;
	650	break;
	651	}
	652	}
	653	if(bad_name){
	654	continue;
	655	}
	656	for(const char *suf = bad_suffixes; suf != NULL; suf++){
	657	size_t suf_len = strlen(*suf);
	658	if((d_name_len >= suf_len)
	659	and (strcmp((dirst->d_name)+d_name_len-suf_len, *suf)
	660	== 0)){
	661	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	662	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	663	" with bad suffix %s\n", dirst->d_name, *suf);
	664	}
	665	bad_name = true;
	666	break;
	667	}
	668	}
	669
	670	if(bad_name){
	671	continue;
	672	}
13 by Björn Påhlsson Added following support:	673	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	674
	675	char *filename;
	676	ret = asprintf(&filename, "%s/%s", plugindir, dirst->d_name);
	677	if(ret < 0){
	678	perror("asprintf");
24.1.46 by Björn Påhlsson mandos-client	679	continue;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	680	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	681
24.1.26 by Björn Påhlsson tally count of used symbols	682	ret = stat(filename, &st);
	683	if (ret == -1){
	684	perror("stat");
24.1.46 by Björn Påhlsson mandos-client	685	free(filename);
24.1.46 by Björn Påhlsson mandos-client	686	continue;
24.1.26 by Björn Påhlsson tally count of used symbols	687	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	688
	689	/* Ignore non-executable files */
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	690	if (not S_ISREG(st.st_mode) or (access(filename, X_OK) != 0)){
	691	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	692	fprintf(stderr, "Ignoring plugin dir entry \"%s\""
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	693	" with bad type or mode\n", filename);
	694	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	695	free(filename);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	696	continue;
	697	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	698
	699	plugin *p = getplugin(dirst->d_name);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	700	if(p == NULL){
	701	perror("getplugin");
	702	free(filename);
	703	continue;
	704	}
	705	if(p->disabled){
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	706	if(debug){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	707	fprintf(stderr, "Ignoring disabled plugin \"%s\"\n",
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	708	dirst->d_name);
	709	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	710	free(filename);
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	711	continue;
	712	}
32 by Teddy Hogeborn * plugins.d/plugbasedclient.c (set_cloexec_flag): New function.	713	{
	714	/* Add global arguments to argument list for this plugin */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	715	plugin *g = getplugin(NULL);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	716	if(g != NULL){
	717	for(char *a = g->argv + 1; a != NULL; a++){
	718	if(not add_argument(p, *a)){
	719	perror("add_argument");
	720	}
	721	}
	722	/* Add global environment variables */
	723	for(char *e = g->environ; e != NULL; e++){
	724	if(not add_environment(p, *e)){
	725	perror("add_environment");
	726	}
	727	}
	728	}
	729	}
	730	/* If this plugin has any environment variables, we will call
	731	using execve and need to duplicate the environment from this
	732	process, too. */
	733	if(p->environ[0] != NULL){
	734	for(char *e = environ; e != NULL; e++){
	735	char copy = strdup(e);
	736	if(copy == NULL){
	737	perror("strdup");
	738	continue;
	739	}
	740	if(not add_environment(p, copy)){
	741	perror("add_environment");
	742	}
	743	}
	744	}
	745
98 by Teddy Hogeborn * plugin-runner.c (getplugin): Only copy "name" if not NULL. Free	746	int pipefd[2];
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	747	ret = pipe(pipefd);
	748	if (ret == -1){
	749	perror("pipe");
	750	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	751	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	752	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	753	/* Ask OS to automatic close the pipe on exec */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	754	ret = set_cloexec_flag(pipefd[0]);
	755	if(ret < 0){
	756	perror("set_cloexec_flag");
	757	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	758	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	759	}
	760	ret = set_cloexec_flag(pipefd[1]);
	761	if(ret < 0){
	762	perror("set_cloexec_flag");
	763	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	764	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	765	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	766	/* Block SIGCHLD until process is safely in process list */
	767	ret = sigprocmask (SIG_BLOCK, &sigchld_action.sa_mask, NULL);
	768	if(ret < 0){
	769	perror("sigprocmask");
	770	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	771	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	772	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	773	// Starting a new process to be watched
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	774	pid_t pid = fork();
24.1.46 by Björn Påhlsson mandos-client	775	if(pid == -1){
	776	perror("fork");
	777	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	778	goto fallback;
24.1.46 by Björn Påhlsson mandos-client	779	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	780	if(pid == 0){
	781	/* this is the child process */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	782	ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
	783	if(ret < 0){
	784	perror("sigaction");
	785	_exit(EXIT_FAILURE);
	786	}
	787	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	788	if(ret < 0){
	789	perror("sigprocmask");
	790	_exit(EXIT_FAILURE);
	791	}
24.1.26 by Björn Påhlsson tally count of used symbols	792
	793	ret = dup2(pipefd[1], STDOUT_FILENO); /* replace our stdout */
	794	if(ret == -1){
	795	perror("dup2");
	796	_exit(EXIT_FAILURE);
	797	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	798
	799	if(dirfd(dir) < 0){
	800	/* If dir has no file descriptor, we could not set FD_CLOEXEC
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	801	above and must now close it manually here. */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	802	closedir(dir);
33 by Teddy Hogeborn * plugins.d/plugbasedclient.c (main): Close the pipe fd after dup2:ing	803	}
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	804	if(p->environ[0] == NULL){
	805	if(execv(filename, p->argv) < 0){
	806	perror("execv");
	807	_exit(EXIT_FAILURE);
	808	}
	809	} else {
	810	if(execve(filename, p->argv, p->environ) < 0){
	811	perror("execve");
	812	_exit(EXIT_FAILURE);
	813	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	814	}
	815	/* no return */
	816	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	817	/* Parent process */
	818	close(pipefd[1]); /* Close unused write end of pipe */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	819	free(filename);
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	820	plugin *new_plugin = getplugin(dirst->d_name);
	821	if (new_plugin == NULL){
	822	perror("getplugin");
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	823	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	824	if(ret < 0){
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	825	perror("sigprocmask");
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	826	}
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	827	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	828	goto fallback;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	829	}
	830
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	831	new_plugin->pid = pid;
	832	new_plugin->fd = pipefd[0];
	833
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	834	/* Unblock SIGCHLD so signal handler can be run if this process
	835	has already completed */
	836	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask, NULL);
	837	if(ret < 0){
	838	perror("sigprocmask");
	839	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	840	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	841	}
	842
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	843	FD_SET(new_plugin->fd, &rfds_all);
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	844
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	845	if (maxfd < new_plugin->fd){
	846	maxfd = new_plugin->fd;
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	847	}
	848
13 by Björn Påhlsson Added following support:	849	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	850
13 by Björn Påhlsson Added following support:	851	closedir(dir);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	852	dir = NULL;
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	853
	854	for(plugin *p = plugin_list; p != NULL; p = p->next){
	855	if(p->pid != 0){
	856	break;
	857	}
	858	if(p->next == NULL){
	859	fprintf(stderr, "No plugin processes started. Incorrect plugin"
	860	" directory?\n");
	861	free_plugin_list();
	862	}
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	863	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	864
	865	/* Main loop while running plugins exist */
	866	while(plugin_list){
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	867	fd_set rfds = rfds_all;
	868	int select_ret = select(maxfd+1, &rfds, NULL, NULL, NULL);
	869	if (select_ret == -1){
	870	perror("select");
	871	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	872	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	873	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	874	/* OK, now either a process completed, or something can be read
	875	from one of them */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	876	for(plugin *proc = plugin_list; proc != NULL; proc = proc->next){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	877	/* Is this process completely done? */
	878	if(proc->eof and proc->completed){
	879	/* Only accept the plugin output if it exited cleanly */
	880	if(not WIFEXITED(proc->status)
	881	or WEXITSTATUS(proc->status) != 0){
	882	/* Bad exit by plugin */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	883
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	884	if(debug){
	885	if(WIFEXITED(proc->status)){
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	886	fprintf(stderr, "Plugin %u exited with status %d\n",
	887	(unsigned int) (proc->pid),
	888	WEXITSTATUS(proc->status));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	889	} else if(WIFSIGNALED(proc->status)) {
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	890	fprintf(stderr, "Plugin %u killed by signal %d\n",
	891	(unsigned int) (proc->pid),
	892	WTERMSIG(proc->status));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	893	} else if(WCOREDUMP(proc->status)){
60 by Teddy Hogeborn * mandos-client.c (main): Cast pid_t to unsigned int before printing.	894	fprintf(stderr, "Plugin %d dumped core\n",
	895	(unsigned int) (proc->pid));
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	896	}
	897	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	898
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	899	/* Remove the plugin */
	900	FD_CLR(proc->fd, &rfds_all);
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	901
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	902	/* Block signal while modifying process_list */
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	903	ret = sigprocmask(SIG_BLOCK, &sigchld_action.sa_mask, NULL);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	904	if(ret < 0){
	905	perror("sigprocmask");
	906	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	907	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	908	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	909	free_plugin(proc);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	910	/* We are done modifying process list, so unblock signal */
	911	ret = sigprocmask (SIG_UNBLOCK, &sigchld_action.sa_mask,
	912	NULL);
	913	if(ret < 0){
	914	perror("sigprocmask");
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	915	exitstatus = EXIT_FAILURE;
	916	goto fallback;
	917	}
	918
	919	if(plugin_list == NULL){
	920	break;
	921	}
	922	continue;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	923	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	924
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	925	/* This process exited nicely, so print its buffer */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	926
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	927	bool bret = print_out_password(proc->buffer,
	928	proc->buffer_length);
24.1.42 by Björn Påhlsson Added fallback to mandos-client	929	if(not bret){
	930	perror("print_out_password");
	931	exitstatus = EXIT_FAILURE;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	932	}
24.1.54 by Björn Påhlsson plugin-runner	933	goto fallback;
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	934	}
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	935
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	936	/* This process has not completed. Does it have any output? */
	937	if(proc->eof or not FD_ISSET(proc->fd, &rfds)){
	938	/* This process had nothing to say at this time */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	939	continue;
	940	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	941	/* Before reading, make the process' data buffer large enough */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	942	if(proc->buffer_length + BUFFER_SIZE > proc->buffer_size){
	943	proc->buffer = realloc(proc->buffer, proc->buffer_size
	944	+ (size_t) BUFFER_SIZE);
	945	if (proc->buffer == NULL){
	946	perror("malloc");
	947	exitstatus = EXIT_FAILURE;
24.1.54 by Björn Påhlsson plugin-runner	948	goto fallback;
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	949	}
	950	proc->buffer_size += BUFFER_SIZE;
	951	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	952	/* Read from the process */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	953	ret = read(proc->fd, proc->buffer + proc->buffer_length,
	954	BUFFER_SIZE);
	955	if(ret < 0){
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	956	/* Read error from this process; ignore the error */
34 by Teddy Hogeborn * plugbasedclient.c (main): Check if plugin dir could be opened. Set	957	continue;
	958	}
	959	if(ret == 0){
	960	/* got EOF */
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	961	proc->eof = true;
	962	} else {
	963	proc->buffer_length += (size_t) ret;
13 by Björn Påhlsson Added following support:	964	}
	965	}
	966	}
24.1.45 by Björn Påhlsson Fixed fallback on error in mandos-client	967
	968
24.1.54 by Björn Påhlsson plugin-runner	969	fallback:
24.1.42 by Björn Påhlsson Added fallback to mandos-client	970
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	971	if(plugin_list == NULL or exitstatus != EXIT_SUCCESS){
102 by Teddy Hogeborn * plugin-runner.c (process): Set "completed" and "status" as volatile.	972	/* Fallback if all plugins failed, none are found or an error
	973	occured */
24.1.42 by Björn Påhlsson Added fallback to mandos-client	974	bool bret;
	975	fprintf(stderr, "Going to fallback mode using getpass(3)\n");
	976	char *passwordbuffer = getpass("Password: ");
	977	bret = print_out_password(passwordbuffer, strlen(passwordbuffer));
	978	if(not bret){
	979	perror("print_out_password");
	980	exitstatus = EXIT_FAILURE;
	981	}
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	982	}
24.1.42 by Björn Påhlsson Added fallback to mandos-client	983
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	984	/* Restore old signal handler */
24.1.54 by Björn Påhlsson plugin-runner	985	ret = sigaction(SIGCHLD, &old_sigchld_action, NULL);
	986	if(ret == -1){
	987	perror("sigaction");
	988	exitstatus = EXIT_FAILURE;
	989	}
	990
	991	if(custom_argv != NULL){
24.1.67 by Björn Påhlsson transformed a function to a part of main	992	for(char *arg = custom_argv+1; arg != NULL; arg++){
24.1.54 by Björn Påhlsson plugin-runner	993	free(*arg);
78 by Teddy Hogeborn Add feature to specify custom environment variables for plugins.	994	}
24.1.54 by Björn Påhlsson plugin-runner	995	free(custom_argv);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	996	}
	997
	998	if(dir != NULL){
	999	closedir(dir);
	1000	}
	1001
	1002	/* Free the process list and kill the processes */
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	1003	for(plugin *p = plugin_list; p != NULL; p = p->next){
	1004	if(p->pid != 0){
	1005	close(p->fd);
	1006	ret = kill(p->pid, SIGTERM);
	1007	if(ret == -1 and errno != ESRCH){
	1008	/* Set-uid proccesses might not get closed */
	1009	perror("kill");
	1010	}
24.1.26 by Björn Påhlsson tally count of used symbols	1011	}
13 by Björn Påhlsson Added following support:	1012	}
13 by Björn Påhlsson Added following support:	1013
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1014	/* Wait for any remaining child processes to terminate */
	1015	do{
	1016	ret = wait(NULL);
	1017	} while(ret >= 0);
	1018	if(errno != ECHILD){
	1019	perror("wait");
	1020	}
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	1021
24.1.76 by Björn Påhlsson Rearranged so plugins and processes is the same thing	1022	free_plugin_list();
	1023
24.1.69 by Björn Påhlsson added configfile as a optional argument to plugin-runner	1024	free(plugindir);
	1025	free(argfile);
35 by Teddy Hogeborn * plugbasedclient.c (struct process): New fields "eof", "completed",	1026
31 by Teddy Hogeborn * plugins.d/plugbasedclient.c: Update include file comments.	1027	return exitstatus;
13 by Björn Påhlsson Added following support:	1028	}